chore: delete unnecessary inheritance of FlowableBufferTimedFlushable#794
Open
OrezzerO wants to merge 4 commits into
Open
chore: delete unnecessary inheritance of FlowableBufferTimedFlushable#794OrezzerO wants to merge 4 commits into
OrezzerO wants to merge 4 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
============================================
+ Coverage 88.50% 88.51% +0.01%
+ Complexity 787 785 -2
============================================
Files 174 174
Lines 7203 7202 -1
Branches 405 405
============================================
Hits 6375 6375
+ Misses 697 696 -1
Partials 131 131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…rTimedFlushable The class no longer requires inheritance from FlowableBufferTimedFlushable as its functionality is redundant. Simplified the class hierarchy for better maintainability.
OrezzerO
force-pushed
the
feat/delete_unused_cdoe
branch
from
289aee3 to
4b88de8
Compare
Author
|
Which part of CHANGELOG.md should I record this PR ? |
Contributor
|
@OrezzerO, please add a new section titled “Features” to the 7.3.0 release notes. Thank you! 😊 |
…rTimedFlushable Add CHANGELOG.md for the refactoring.
Author
|
@bednar CHANGELOG.md updated. |
bednar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
FlowableBufferTimedFlushable doesn't need to inherit from FlowableTransformer. Therefore, delete this inheritance relationship to reduce the complexity of the code. The original implementation was quite confusing.
Checklist
mvn testcompletes successfully